Files
cbb-refresh-verify-795/docs/superpowers/plans/2026-11-09-other-pr-latest-reviews.md
T

2.0 KiB

Latest reviews for PR #10/#11/#12

Scope: user selected only the 2026-11-09 comments #309/#310/#313. Earlier deep-review backlog stays out of scope. Preserve ICDB automatic Repair OFF, serial writes, current icon and independent-library admission. No merge to main, issue closure or release.

PR #10

  • Reproduce BlockA releasing historical BlockB checkpoints and retained owners without naming BlockB in proof.
  • Record requested block, actual proof scope, checkpoint identities and foreign names in existing release proof. Preserve original checkpoint bytes and data_recovery_confirmed=False; no new blocking gate.
  • Run backend/lease regressions, compile/diff checks, commit on codex/review-native-backend.

PR #11/#12

  • Forward-merge backend into UI, then UI into residual branch; no history rewriting.
  • Test one unreadable process/thread not affecting another, without fabricated modal windows; cover preview and action-time rechecks.
  • Enumerate only target-process threads/windows, store incomplete-read metadata per PID. Keep unknown/active writers protected rather than adding a blind force override.
  • Persist window identities and at most a 4 KiB output excerpt, preserve full preview in memory, stop duplicating activity output.
  • Carry exact preview block scope into native Cancel and recheck identity/scope before clicking.
  • Run residual/UI regressions, compile/diff checks, commit on residual branch.

Chain tip

  • Merge residual fixes into PR #13, preserving ca39fb3 and icon.
  • Address #11's line-ending note once at the tip: application.py to LF; pin it and main_window.py with targeted .gitattributes exceptions. Preserve all other file endings and the global * -text rule; EditorConfig is unnecessary.
  • Independent review, integrated full suite, compile/diff checks, validation records and fast-forward pushes to existing PR branches.
  • Update PR descriptions with precise results and no new package/native acceptance. Leave #3 as historical umbrella, without merging or closing it.