Files
cbb-refresh-verify-795/tests/test_management.py
T

255 lines
11 KiB
Python

"""Operation safety tests use a file-only native boundary; never launch Mentor."""
from dataclasses import replace
import json
from pathlib import Path
from threading import Event
import pytest
def project(root, name='Source', marker=b'original'):
root.mkdir(parents=True)
(root/'database').mkdir()
(root/'database/icdb.dat').write_bytes(marker)
(root/'PCB/Layout').mkdir(parents=True)
(root/'PCB/Layout/LayoutDB.lyt').write_bytes(marker)
(root/'PCB/pcb.prj').write_text('KEY iCDBDir "../database"\n', encoding='utf-8')
(root/'PCB/main.pcb').write_text(f'KEY ProjectFile "../{name}.prj"\n', encoding='utf-8')
path = root/f'{name}.prj'
path.write_text('KEY RootBlock "Top"\nKEY PCBDesignPath "PCB/main.pcb"\n'
'KEY iCDBDir "database"\n', encoding='utf-8')
return path
class FileAdapter:
def __init__(self):
self.records = []
self.calls = []
self.fail_add = False
self.lie = False
self.released = True
def capabilities(self):
from cbb_refresh_verify.management import Capability
return {op: Capability(True, 'test boundary') for op in ('add', 'update', 'remove')}
def catalog(self, library, evidence):
from cbb_refresh_verify.management import Catalog
return Catalog(library, 1, tuple(self.records), safe_to_continue=self.released)
def remove(self, request, evidence):
from cbb_refresh_verify.management import NativeOutcome
self.calls.append('remove')
if not self.lie:
self.records = [r for r in self.records if r.name != request.name]
return NativeOutcome(True, self.released, 'native removal accepted')
def add(self, request, evidence):
from cbb_refresh_verify.management import NativeOutcome, CatalogEntry, engineering_identity
self.calls.append(('add', request.source))
if self.fail_add:
return NativeOutcome(False, self.released, 'native add failed')
if not self.lie:
self.records.append(CatalogEntry(request.name, request.partition,
engineering_identity(request.source)))
return NativeOutcome(True, self.released, 'native add accepted')
@pytest.fixture
def setup(tmp_path):
from cbb_refresh_verify.management import ManagementRequest, CatalogEntry
library = tmp_path/'library/mentor.lmc'
library.parent.mkdir()
library.write_bytes(b'library')
old = project(library.parent/'ReusableBlocksLP/Block/Work', 'Block')
source = project(tmp_path/'source')
adapter = FileAdapter()
adapter.records = [CatalogEntry('Block', 'Logical-Physical')]
request = ManagementRequest('remove', library, 'Block', evidence_dir=tmp_path/'evidence')
yield request, adapter, source
# FileAdapter never launches native owners. Release only this test's
# intentionally retained lease so pytest can remove its temporary tree.
from cbb_refresh_verify.library_lock import _guard, _owners
key = str(library.with_name('.mentor.cbb-upload.lock').resolve()).casefold()
with _guard:
owner = _owners.pop(key, None)
if owner:
owner['handle'].Close()
def execute(request, adapter, **kwargs):
from cbb_refresh_verify.management import run_management
return run_management(request, adapter=adapter, idle_check=lambda *_: None, **kwargs)
def test_remove_backup_and_strict_absence(setup):
request, adapter, _ = setup
result = execute(request, adapter)
assert result.status == 'REMOVED' and result.safe_to_continue
assert (result.evidence_path.parent/'library-before/mentor.lmc').read_bytes() == b'library'
assert (result.evidence_path.parent/'library-before/ReusableBlocksLP/Block/Work/Block.prj').is_file()
record = json.loads(result.evidence_path.read_text(encoding='utf-8'))
assert record['operation'] == 'remove' and record['partition'] == 'Logical-Physical'
assert record['stage'] == 'complete'
def test_add_conflict_cannot_overwrite(setup):
request, adapter, source = setup
result = execute(replace(request, operation='add', source=source), adapter)
assert result.status == 'UPLOAD_FAILED' and adapter.calls == []
@pytest.mark.parametrize('verify_status,flag,expected', [('PASS', 'GREEN', 'UPLOADED_VERIFIED'),
('FAIL', 'RED', 'UPLOADED_VERIFY_FAILED'), ('PASS', 'UNKNOWN', 'UPLOADED_VERIFY_FAILED')])
def test_add_stages_source_and_requires_authoritative_verify(setup, verify_status, flag, expected):
from cbb_refresh_verify.verify_runner import VerifyResult
request, adapter, source = setup
original = source.read_bytes()
def verifier(req, **_):
assert adapter.released
return VerifyResult(verify_status, library_flag=flag)
result = execute(replace(request, operation='add', name='New', source=source), adapter,
verifier=verifier)
assert result.status == expected and source.read_bytes() == original
assert adapter.calls[0][1] != source
assert adapter.calls[0][1].is_relative_to(result.evidence_path.parent)
def test_add_no_auto_verify_and_reimport_after_remove(setup):
request, adapter, source = setup
assert execute(request, adapter).status == 'REMOVED'
result = execute(replace(request, operation='add', source=source, auto_verify=False), adapter,
verifier=lambda *_: pytest.fail('auto verify disabled'))
assert result.status == 'UPLOADED'
def test_update_failed_readd_keeps_removed_checkpoint_and_recovery_snapshot(setup):
request, adapter, source = setup
adapter.fail_add = True
result = execute(replace(request, operation='update', source=source), adapter)
assert result.status == 'RECOVERY_REQUIRED' and not result.safe_to_continue
assert adapter.records == []
history = json.loads(result.evidence_path.read_text(encoding='utf-8'))['history']
assert 'removed' in [x['stage'] for x in history]
assert (result.evidence_path.parent/'library-before/mentor.lmc').is_file()
@pytest.mark.parametrize('operation', ['remove', 'add'])
def test_lying_native_output_does_not_report_success(setup, operation):
request, adapter, source = setup
adapter.lie = True
request = replace(request, operation=operation, source=source,
name='New' if operation == 'add' else 'Block')
result = execute(request, adapter)
assert result.status == 'RECOVERY_REQUIRED' and not result.safe_to_continue
def test_unreleased_native_owner_prevents_postread_and_verification(setup):
request, adapter, _ = setup
original = adapter.remove
def unreleased(*args):
adapter.released = False
return original(*args)
adapter.remove = unreleased
reads = []
catalog = adapter.catalog
adapter.catalog = lambda *a: (reads.append(1) or catalog(*a))
result = execute(request, adapter, verifier=lambda *_: pytest.fail('unsafe verify'))
assert not result.safe_to_continue and len(reads) == 1
from cbb_refresh_verify.library_lock import LibraryLock, LibraryBusy
with pytest.raises(LibraryBusy):
with LibraryLock(request.library):
pass
@pytest.mark.parametrize('name', ['../escape', 'A\tB', 'A\nB', 'A/B', 'NUL', 'a.', ''])
def test_invalid_native_identity_rejected_before_writes(setup, name):
request, adapter, _ = setup
result = execute(replace(request, name=name), adapter)
assert result.status == 'BLOCKED' and adapter.calls == []
def test_evidence_inside_target_rejected(setup):
request, adapter, _ = setup
result = execute(replace(request, evidence_dir=request.library.parent/'evidence'), adapter)
assert result.status == 'BLOCKED' and not (request.library.parent/'evidence').exists()
def test_cancel_and_restart_never_replay(setup):
from cbb_refresh_verify.management import run_management_batch, unfinished_operations
request, adapter, _ = setup
stop = Event(); stop.set()
assert run_management_batch([request], stop=stop, adapter=adapter) == []
checkpoint = request.evidence_dir/'interrupted/checkpoint.json'
checkpoint.parent.mkdir(parents=True)
checkpoint.write_text('{"stage":"native_remove", "status":"RUNNING"}', encoding='utf-8')
found = unfinished_operations(request.evidence_dir)
assert len(found) == 1 and found[0]['evidence_path'] == str(checkpoint)
assert adapter.calls == []
def test_capability_gate_enforced_below_ui(setup):
from cbb_refresh_verify.management import Capability
request, adapter, source = setup
adapter.capabilities = lambda: {'add': Capability(False, 'isolated add not validated')}
result = execute(replace(request, operation='add', name='New', source=source), adapter)
assert result.status == 'UNSUPPORTED' and 'isolated' in result.detail
assert adapter.calls == []
def test_timeout_stops_batch_and_persists_ambiguous_native_stage(setup):
from cbb_refresh_verify.management import run_management_batch
request, adapter, _ = setup
def timeout(*_):
raise TimeoutError('network timeout')
adapter.remove = timeout
results = run_management_batch([request, replace(request, name='Other')], adapter=adapter,
idle_check=lambda *_: None)
assert len(results) == 1 and not results[0].safe_to_continue
assert results[0].status == 'RECOVERY_REQUIRED'
def test_catalog_timeout_is_not_safe_to_continue(setup):
request, adapter, _ = setup
def timeout(*_):
raise TimeoutError('catalog owner still running')
adapter.catalog = timeout
result = execute(request, adapter)
assert not result.safe_to_continue and adapter.calls == []
def test_replaced_source_bytes_fail_identity_even_with_same_name(setup):
request, adapter, source = setup
real_add = adapter.add
def wrong_source(*args):
from cbb_refresh_verify.management import CatalogEntry
result = real_add(*args)
entry = adapter.records[-1]
adapter.records[-1] = CatalogEntry(entry.name, entry.partition, {'wrong': 'project'})
return result
adapter.add = wrong_source
result = execute(replace(request, operation='add', name='New', source=source), adapter)
assert result.status == 'RECOVERY_REQUIRED' and not result.safe_to_continue
def test_update_success_requires_same_identity_and_no_implicit_partition_move(setup):
request, adapter, source = setup
result = execute(replace(request, operation='update', source=source, partition='Other'), adapter)
assert result.status == 'BLOCKED' and not adapter.calls
result = execute(replace(request, operation='update', source=source, auto_verify=False), adapter)
assert result.status == 'UPLOADED'
assert adapter.calls[0] == 'remove' and adapter.calls[1][0] == 'add'
def test_verify_exception_after_upload_retains_coordination_lock(setup):
from cbb_refresh_verify.library_lock import LibraryLock, LibraryBusy
request, adapter, source = setup
def broken_verifier(*a, **k):
raise OSError('verification worker disconnected')
result = execute(replace(request, operation='add', name='New', source=source), adapter,
verifier=broken_verifier)
assert result.status == 'UPLOADED_VERIFY_FAILED' and not result.safe_to_continue
with pytest.raises(LibraryBusy):
with LibraryLock(request.library):
pass