from dx_productivity.dsh.resume_diff import resume_diff from dx_productivity.dsh.run_journal import RunJournal from test_run_journal import project_service, checkpoint, evidence from dx_productivity.trial_task_center.task_queue import _plan_hash from dx_productivity.trial_task_center.models import TaskStatus import pytest def test_real_service_plan_changes_are_reported(project_service): service, _, data, ids, hashes = project_service journal = RunJournal(data) journal.begin('a' * 32, ids, hashes) checkpoint(data, 'a' * 32, ids, hashes) rule = service.rules(ids[0])[0] service.update_rule(rule.rule_id, old_part_number='OLD', new_part_number='DIFFERENT', enabled=True) report = journal.inspect(service, 'a' * 32) assert ids[0] in report['diff']['changed'] change = next(row for row in report['diff']['plan_changes'] if row['task_id'] == ids[0]) assert change['saved'] == hashes[ids[0]] and change['current'] != change['saved'] assert report['diff']['safe'] is False def test_real_service_uses_original_checkpoint_remaining_scope(project_service): service, _, data, ids, hashes = project_service journal = RunJournal(data) journal.begin('a' * 32, ids, hashes) checkpoint(data, 'a' * 32, ids, hashes) report = journal.inspect(service, 'a' * 32) assert report['diff']['safe'] is True assert report['diff']['remaining'] == ids assert report['diff']['completed'] == [] def test_evidence_counter_changes_since_receipt_are_visible(project_service): service, _, data, ids, hashes = project_service journal = RunJournal(data) journal.begin('a' * 32, ids, hashes) checkpoint(data, 'a' * 32, ids, hashes) journal.finish('a' * 32, {'status': 'paused', 'tasks': [{'task_id': ids[0], 'no_match_items': 0}]}) evidence(service, ids[0]) report = journal.inspect(service, 'a' * 32) assert {'task_id': ids[0], 'field': 'no_match_items', 'saved': 0, 'current': 1} in report['diff']['evidence_changes'] assert 'evidence_changed' in report['diff']['blockers'] def test_missing_current_hash_cannot_be_silently_ignored(project_service): service, _, _, ids, hashes = project_service value = resume_diff(service, {'task_ids': ids, 'plan_hashes': {}, 'remaining_task_ids': ids, 'queue_available': True, 'resume_ready': True, 'tasks': []}) assert value['safe'] is False assert value['changed'] == ids def test_completed_checkpoint_requires_matching_current_evidence(project_service): service, _, data, ids, hashes = project_service journal = RunJournal(data) journal.begin('c' * 32, ids, hashes) checkpoint(data, 'c' * 32, ids, hashes, {ids[0]: 'completed'}) report = journal.inspect(service, 'c' * 32) assert not report['resume_ready'] assert 'checkpoint_evidence_mismatch' in report['blockers'] evidence(service, ids[0]) assert journal.inspect(service, 'c' * 32)['resume_ready'] @pytest.mark.parametrize('checkpoint_state', ['running', 'completed']) def test_crash_during_resumed_run_accepts_verified_progress_but_not_old_terminal_changes(project_service, checkpoint_state): service, store, data, ids, _ = project_service hashes = {key: _plan_hash(service.for_project_task(key), key) for key in ids} journal = RunJournal(data) journal.begin('b' * 32, ids, hashes) evidence(service, ids[0]) for state in (TaskStatus.READY, TaskStatus.RUNNING, TaskStatus.COMPLETED): store.set_task_status(ids[0], state) checkpoint(data, 'b' * 32, ids, hashes, {ids[0]: 'completed', ids[1]: 'paused'}) baseline = [] for task_id in ids: context = service.task_context(task_id) baseline.append({'task_id': task_id, 'interrupted': context.interrupted, **{key: getattr(context.progress, key) for key in ('saved_items', 'failed_items', 'no_match_items', 'queue_complete')}}) journal.finish('b' * 32, {'status': 'paused', 'tasks': baseline, 'entries': [{'task_id': key, 'state': 'completed' if key == ids[0] else 'paused' if key == ids[1] else 'pending'} for key in ids]}) assert journal.inspect(service, 'b' * 32)['resume_ready'] journal.resume('b' * 32) evidence(service, ids[1]) for state in (TaskStatus.READY, TaskStatus.RUNNING, TaskStatus.COMPLETED): store.set_task_status(ids[1], state) checkpoint(data, 'b' * 32, ids, hashes, {ids[0]: 'completed', ids[1]: checkpoint_state}) report = journal.inspect(service, 'b' * 32) assert report['resume_ready'], report['blockers'] assert report['diff']['evidence_changes'] assert all(row['expected_progress'] for row in report['diff']['evidence_changes']) # The run cannot rewrite or lose evidence for a task already terminal in # the last durable receipt, even while later tasks legitimately advance. root = service.for_project_task(ids[0])._quick_run_preparer.data_root / 'quick-run' (root / 'status.tsv').write_text('job_id\tstate\tcode\tmessage\n', encoding='utf8') changed = journal.inspect(service, 'b' * 32) assert not changed['resume_ready'] and 'evidence_changed' in changed['blockers']