114 lines
6.1 KiB
Python
114 lines
6.1 KiB
Python
"""A successful inventory retry must not hide leaked resources from an earlier attempt."""
|
|
import copy
|
|
import importlib
|
|
import json
|
|
from pathlib import Path
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def native_bom_evidence(tmp_path,monkeypatch):
|
|
monkeypatch.syspath_prepend(str(Path(__file__).resolve().parents[2]/'tools'))
|
|
verifier=importlib.import_module('accept_packaged_ui')
|
|
projects=[tmp_path/'A.prj',tmp_path/'B.prj']
|
|
(tmp_path/'inputs.json').write_text(json.dumps({'projects':[str(p) for p in projects]}))
|
|
(tmp_path/'desktop-observation-bom.json').write_text(json.dumps(dict(
|
|
sessions={},observer_errors=[],cad_exit_confirmed={},desktop_absent={},
|
|
owned_cad_became_foreground=False,owned_cad_on_input_desktop=False,
|
|
input_desktop_before='Default',input_desktop_after='Default',samples=2,file_read_samples=2)))
|
|
rows=[]
|
|
for i,project in enumerate(projects):
|
|
row=dict(backend='native_cli',project=str(project),state='ready',
|
|
workspace=str(tmp_path/f'released-{i}'),source_hashes_unchanged=True,
|
|
cleanup=dict(desktop_handle_closed=True,desktop_confirmation={'released':True},errors=[],
|
|
processes=[dict(job_active_processes=0,exit_code=0,process_handle_closed=True,
|
|
job_handle_closed=True,unconfirmed_descendant_handles=0,errors=[])]))
|
|
path=tmp_path/f'data/tasks/{i}/quick-run-history/native-inventory-ok/native-inventory.json'
|
|
path.parent.mkdir(parents=True);path.write_text(json.dumps(row));rows.append(row)
|
|
return verifier,tmp_path,rows
|
|
|
|
|
|
def test_bom_resource_verifier_accepts_cli_only_reads_without_cad(native_bom_evidence):
|
|
verifier,root,_=native_bom_evidence
|
|
assert verifier.verify_bom_resources(root)=={'cad_sessions':0,'ready_native_cli_reads':2}
|
|
|
|
|
|
@pytest.mark.parametrize('fault', [None, 'pending', 'unbound', 'workers_open'])
|
|
def test_bom_resource_verifier_checks_batch_release_and_operation_binding(native_bom_evidence, fault):
|
|
verifier, root, rows = native_bom_evidence
|
|
operations = {}
|
|
for i, row in enumerate(rows):
|
|
path = root / f'data/tasks/{i}/quick-run-history/native-inventory-ok/native-inventory.json'
|
|
row['cleanup'].update(scope='operation', workers_closed=True, desktop_retained_by_batch=True)
|
|
path.write_text(json.dumps(row))
|
|
operations[str(path.parent.resolve())] = {'workers_closed': fault != 'workers_open',
|
|
'binding': {'session_id': 'batch', 'generation': 1, 'attempt_id': str(i)}}
|
|
if fault == 'unbound':
|
|
operations.clear()
|
|
path = root / 'data/batch-resources/batch/session.json'
|
|
path.parent.mkdir(parents=True)
|
|
path.write_text(json.dumps(dict(state='blocked' if fault == 'pending' else 'released',
|
|
session_id='batch', generation=1, native_operations=operations,
|
|
cleanup=dict(desktop_handle_closed=True, desktop_confirmation={'released':True}, errors=[]))))
|
|
if fault:
|
|
with pytest.raises(AssertionError):
|
|
verifier.verify_bom_resources(root)
|
|
else:
|
|
assert verifier.verify_bom_resources(root)['ready_native_cli_reads'] == 2
|
|
|
|
|
|
@pytest.mark.parametrize('fault',['uncertain','fallback_active_job','fallback_retained_workspace'])
|
|
def test_bom_resource_verifier_rejects_bad_earlier_attempt_despite_clean_retries(native_bom_evidence,fault):
|
|
verifier,root,rows=native_bom_evidence
|
|
extra=copy.deepcopy(rows[0]);extra['state']='fallback'
|
|
if fault=='uncertain':
|
|
extra['state']='uncertain';extra['cleanup_error']='Job did not exit'
|
|
elif fault=='fallback_active_job':
|
|
extra['cleanup']['processes'][0]['job_active_processes']=1
|
|
else:
|
|
workspace=root/'retained-workspace';workspace.mkdir();extra['workspace']=str(workspace)
|
|
path=root/'data/tasks/0/quick-run-history/native-inventory-earlier/native-inventory.json'
|
|
path.parent.mkdir(parents=True);path.write_text(json.dumps(extra))
|
|
with pytest.raises(AssertionError):verifier.verify_bom_resources(root)
|
|
|
|
|
|
@pytest.mark.parametrize('state',['failed','blocked'])
|
|
def test_execution_wait_rejects_retryable_failure_even_when_task_status_remains_running(native_bom_evidence,state):
|
|
verifier,root,_=native_bom_evidence
|
|
directory=root/'data/task-queues';directory.mkdir()
|
|
path=directory/'current.json'
|
|
path.write_text(json.dumps({'task_ids':['a','b'],'entries':{
|
|
'a':{'state':state,'message':'Native target query timed out'},
|
|
'b':{'state':'pending','message':''}}}))
|
|
with pytest.raises(AssertionError,match='do not auto-retry'):
|
|
verifier.execution_complete(root,[{'task_id':'a','status':'running'},
|
|
{'task_id':'b','status':'ready'}],set())
|
|
|
|
|
|
def test_execution_wait_ignores_old_queue_failures(native_bom_evidence):
|
|
verifier,root,_=native_bom_evidence
|
|
directory=root/'data/task-queues';directory.mkdir()
|
|
old=directory/'old.json';old.write_text(json.dumps({'task_ids':['a'],'entries':{'a':{'state':'failed'}}}))
|
|
assert not verifier.execution_complete(root,[{'task_id':'a','status':'running'}],{old})
|
|
|
|
|
|
def test_execution_wait_requires_current_queue_and_tasks_completed(native_bom_evidence):
|
|
verifier,root,_=native_bom_evidence
|
|
tasks=[{'task_id':'a','status':'completed'}]
|
|
assert not verifier.execution_complete(root,tasks,set())
|
|
directory=root/'data/task-queues';directory.mkdir()
|
|
path=directory/'current.json'
|
|
path.write_text(json.dumps({'task_ids':['a'],'entries':{'a':{'state':'running'}}}))
|
|
assert not verifier.execution_complete(root,tasks,set())
|
|
path.write_text(json.dumps({'task_ids':['a'],'entries':{'a':{'state':'completed'}}}))
|
|
assert verifier.execution_complete(root,tasks,set())
|
|
|
|
|
|
@pytest.mark.parametrize('entries',[{}, {'wrong-task':{'state':'completed'}}])
|
|
def test_execution_wait_rejects_incomplete_checkpoint(native_bom_evidence,entries):
|
|
verifier,root,_=native_bom_evidence
|
|
directory=root/'data/task-queues';directory.mkdir()
|
|
(directory/'current.json').write_text(json.dumps({'task_ids':['a'],'entries':entries}))
|
|
with pytest.raises(AssertionError,match='Incomplete queue checkpoint'):
|
|
verifier.execution_complete(root,[{'task_id':'a','status':'completed'}],set())
|