137 lines
6.7 KiB
Python
137 lines
6.7 KiB
Python
import pytest
|
|
|
|
from dx_productivity.trial_task_center.errors import TaskCenterError
|
|
from dx_productivity.trial_task_center.logging_setup import configure_logging
|
|
from dx_productivity.trial_task_center.models import TaskStatus
|
|
from dx_productivity.trial_task_center.service import TaskCenterService
|
|
from dx_productivity.trial_task_center.store import TaskStore
|
|
from dx_productivity.trial_task_center.target_plan import ComponentTarget, TargetPlanRow
|
|
|
|
|
|
@pytest.fixture
|
|
def batch(tmp_path):
|
|
root = tmp_path / 'projects'
|
|
for name in ('a', 'b'):
|
|
folder = root / name
|
|
folder.mkdir(parents=True)
|
|
(folder / 'board.prj').write_text('KEY FrontEndSnapshot "DxD"\nKEY iCDBDir "database"\n')
|
|
store = TaskStore(tmp_path / 'tasks.db')
|
|
app = TaskCenterService(store, configure_logging(tmp_path / 'data'))
|
|
tasks = app.create_project_tasks(root)
|
|
yield app, store, tasks
|
|
store.close()
|
|
|
|
|
|
def values(rules):
|
|
return [(r.old_part_number, r.new_part_number, r.enabled, r.sync_nc) for r in rules]
|
|
|
|
|
|
def test_rule_crud_and_order_are_shared_across_projects(batch):
|
|
app, store, tasks = batch
|
|
a, b = (t.task_id for t in tasks)
|
|
first = app.add_rule(a, 'OLD', 'NEW')
|
|
assert values(app.rules(a)) == values(app.rules(b)) == [('OLD', 'NEW', True, True)]
|
|
second = app.add_rule(b, 'OTHER', 'OTHER-NEW', sync_nc=False)
|
|
app.move_rule(second.rule_id, -1)
|
|
assert values(app.rules(a)) == values(app.rules(b))
|
|
assert app.rules(a)[0].old_part_number == 'OTHER'
|
|
app.update_rule(first.rule_id, old_part_number='OLD', new_part_number='NEW2', enabled=False)
|
|
assert values(app.rules(a)) == values(app.rules(b))
|
|
app.delete_rule(first.rule_id)
|
|
assert values(app.rules(a)) == values(app.rules(b)) == [('OTHER', 'OTHER-NEW', True, False)]
|
|
|
|
|
|
def test_rule_change_updates_execution_defaults_but_keeps_manual_fields_and_selection(batch):
|
|
app, store, tasks = batch
|
|
rule = app.add_rule(tasks[0].task_id, 'OLD', 'NEW1')
|
|
for task in tasks:
|
|
path = store.list_projects(task.task_id)[0].path
|
|
targets = tuple(ComponentTarget(path, 'MAIN', '1', f'u{i}', f'R{i}', 'OLD', 'V0') for i in (1, 2, 3))
|
|
store.record_target_inventory(task.task_id, targets)
|
|
store.replace_target_plan(task.task_id, (
|
|
TargetPlanRow(targets[0], True, 'NEW1'),
|
|
TargetPlanRow(targets[1], True, 'MANUAL', True, 'custom', False),
|
|
TargetPlanRow(targets[2], False, 'NEW1'),
|
|
))
|
|
app.update_rule(rule.rule_id, old_part_number='OLD', new_part_number='NEW2', enabled=True,
|
|
custom_value_enabled=True, custom_value='rule value', sync_nc=False)
|
|
for task in tasks:
|
|
rows = app.target_plan(task.task_id)
|
|
assert [(r.enabled, r.new_part_number) for r in rows] == [(True, 'NEW2'), (True, 'MANUAL'), (False, 'NEW2')]
|
|
assert rows[0].custom_value == 'rule value' and not rows[0].sync_nc
|
|
assert rows[1].custom_value == 'custom' and not rows[1].sync_nc
|
|
effective = app._execution_rules(task.task_id)
|
|
assert {r.new_part_number for r in effective} == {'NEW2', 'MANUAL'}
|
|
assert app.task_context(task.task_id).targets == rows
|
|
|
|
|
|
def test_frozen_sibling_rejects_entire_rule_mutation(batch):
|
|
app, store, tasks = batch
|
|
rule = app.add_rule(tasks[0].task_id, 'OLD', 'NEW1')
|
|
store.set_task_status(tasks[1].task_id, TaskStatus.READY)
|
|
store.set_task_status(tasks[1].task_id, TaskStatus.RUNNING)
|
|
before = {t.task_id: app.rules(t.task_id) for t in tasks}
|
|
with pytest.raises(TaskCenterError):
|
|
app.update_rule(rule.rule_id, old_part_number='OLD', new_part_number='NEW2', enabled=True)
|
|
assert before == {t.task_id: app.rules(t.task_id) for t in tasks}
|
|
|
|
|
|
def test_failure_on_sibling_rolls_back_rules_and_target_defaults(batch, monkeypatch):
|
|
app, store, tasks = batch
|
|
rule = app.add_rule(tasks[0].task_id, 'OLD', 'NEW1')
|
|
path = store.list_projects(tasks[0].task_id)[0].path
|
|
target = ComponentTarget(path, 'MAIN', '1', 'u', 'R1', 'OLD', '')
|
|
store.record_target_inventory(tasks[0].task_id, (target,))
|
|
store.replace_target_plan(tasks[0].task_id, (TargetPlanRow(target, True, 'NEW1'),))
|
|
original = store.update_rule
|
|
def fail(rule_id, **kwargs):
|
|
if store.get_rule(rule_id).task_id == tasks[1].task_id:
|
|
raise TaskCenterError('injected', 'sibling write failed')
|
|
return original(rule_id, **kwargs)
|
|
monkeypatch.setattr(store, 'update_rule', fail)
|
|
with pytest.raises(TaskCenterError, match='sibling write failed'):
|
|
app.update_rule(rule.rule_id, old_part_number='OLD', new_part_number='NEW2', enabled=True)
|
|
assert all(app.rules(t.task_id)[0].new_part_number == 'NEW1' for t in tasks)
|
|
assert app.target_plan(tasks[0].task_id)[0].new_part_number == 'NEW1'
|
|
|
|
|
|
def test_legacy_group_disagreement_is_reported_instead_of_silent_partial_edit(batch):
|
|
app, store, tasks = batch
|
|
first = store.add_rule(tasks[0].task_id, 'OLD', 'A')
|
|
store.add_rule(tasks[1].task_id, 'OLD', 'B')
|
|
with pytest.raises(TaskCenterError, match='不一致'):
|
|
app.add_rule(tasks[0].task_id, 'OTHER', 'NEW')
|
|
# Editing the conflicting mapping explicitly resolves that old-number rule.
|
|
app.update_rule(first.rule_id, old_part_number='OLD', new_part_number='C', enabled=True)
|
|
assert all(app.rules(t.task_id)[0].new_part_number == 'C' for t in tasks)
|
|
|
|
|
|
@pytest.mark.parametrize('last_target, code', [('NEW', 'mapping_chain'), ('OLD', 'mapping_cycle')])
|
|
def test_legacy_rule_union_is_validated_before_execution_and_collection(batch, last_target, code):
|
|
app, store, tasks = batch
|
|
store.add_rule(tasks[0].task_id, 'OLD', 'MID')
|
|
store.add_rule(tasks[1].task_id, 'MID', last_target)
|
|
# Display remains available so a historical conflict can be corrected.
|
|
assert len(app.rules(tasks[0].task_id)) == 2
|
|
for task in tasks:
|
|
with pytest.raises(TaskCenterError) as error:
|
|
app._execution_rules(task.task_id)
|
|
assert error.value.code == code
|
|
with pytest.raises(TaskCenterError) as error:
|
|
app.collect_target_inventory(task.task_id)
|
|
assert error.value.code == code
|
|
|
|
|
|
@pytest.mark.parametrize('action', ['disable', 'delete'])
|
|
def test_historical_chain_can_be_resolved_through_normal_rule_edit(batch, action):
|
|
app, store, tasks = batch
|
|
store.add_rule(tasks[0].task_id, 'OLD', 'MID')
|
|
selected = store.add_rule(tasks[1].task_id, 'MID', 'NEW')
|
|
if action == 'disable':
|
|
updated = app.update_rule(selected.rule_id, old_part_number='MID', new_part_number='NEW', enabled=False)
|
|
assert updated.rule_id == selected.rule_id
|
|
else:
|
|
app.delete_rule(selected.rule_id)
|
|
assert values(app.rules(tasks[0].task_id)) == values(app.rules(tasks[1].task_id))
|
|
assert all([r.old_part_number for r in app._execution_rules(t.task_id) if r.enabled] == ['OLD'] for t in tasks)
|