diff --git a/src/app/application.cjs b/src/app/application.cjs index a9905f1..641685e 100644 --- a/src/app/application.cjs +++ b/src/app/application.cjs @@ -31,6 +31,7 @@ const { OrderExecutionCoordinator } = require('../modules/order-execution/coordi async function closeServer(server){ if(!server)return; + server.closeAssistantStreams?.(); // An unbound dashboard still owns its session DB. if(!server.listening){await server.drainExports?.();server.closeSessionStore?.();return;} await new Promise((resolve,reject)=>server.close(error=>error?reject(error):resolve())); diff --git a/src/app/dashboard.cjs b/src/app/dashboard.cjs index bdfffeb..d470e0d 100644 --- a/src/app/dashboard.cjs +++ b/src/app/dashboard.cjs @@ -19,6 +19,7 @@ const {BpmConnectionLifecycle}=require('../modules/bpm/connection-lifecycle.cjs' function createDashboard({store,outputDir,workspace,bpmSessions,bpmMonitor,mail,scanner,storage,notifications,orderRules,orderExecution,orderDispatcher,assistant,health,watchdog,trustedProxy=false}) { const bpmLifecycle=workspace?new BpmConnectionLifecycle({workspace,manager:bpmSessions,monitor:bpmMonitor}):null; const auth=createAuth({store,workspace,bpmSessions,bpmMonitor,bpmLifecycle}); + const streams=assistant?new(require('../modules/assistant/event-stream.cjs').AssistantStreams)({store:assistant.store}):null; let assetFor;try{assetFor=createAssets();}catch(error){auth.close();throw error;} const server=http.createServer(async(request,response)=>{ if(respondToPing(request,response,watchdog))return; @@ -47,14 +48,15 @@ function createDashboard({store,outputDir,workspace,bpmSessions,bpmMonitor,mail, if(await orderRuleQueryApi({orderRules,execution:orderExecution,workspace,user,url,route,method:request.method,reply,response}))return; if(await orderExecutionApi({execution:orderExecution,orderRules,dispatcher:orderDispatcher,workspace,user,sessionId:token,url,route,method:request.method,body,reply}))return; if(await orderRuleApi({orderRules,mail,workspace,user,url,route,method:request.method,body,reply,response}))return; - if(await assistantApi({assistant,workspace,user,sessionId:token,route,method:request.method,body,request,reply,trustedProxy}))return; + if(await assistantApi({assistant,workspace,user,sessionId:token,route,method:request.method,body,request,response,streams,authenticateStream:()=>auth.current(request),reply,trustedProxy}))return; if(await workspaceApi({workspace,store,user,route,method:request.method,body,reply,bpmSessions,bpmMonitor,bpmLifecycle,orderRules}))return; if(await dashboardApi({store,outputDir,workspace,mail,scanner,storage,orderRules,user,route,request,response,body,reply,fail}))return; fail(404,'没有找到此页面或操作。'); }catch(error){if(!response.headersSent){if(!error.status)console.error('看板处理失败:',error.message);reply(error.status || 500,{error:error.status?error.message:'处理失败,请检查服务日志。'});}else response.end();} }); - server.closeSessionStore=()=>auth.close(); - server.once('close',()=>auth.close());server.once('error',()=>{if(!server.listening)auth.close();}); + server.closeAssistantStreams=()=>streams?.close(); + server.closeSessionStore=()=>{streams?.close();auth.close();}; + server.once('close',()=>{streams?.close();auth.close();});server.once('error',()=>{if(!server.listening){streams?.close();auth.close();}}); return server; } module.exports={createDashboard}; diff --git a/src/modules/assistant/api.cjs b/src/modules/assistant/api.cjs index 4750ee7..07e3daf 100644 --- a/src/modules/assistant/api.cjs +++ b/src/modules/assistant/api.cjs @@ -1,16 +1,29 @@ 'use strict'; const {fail}=require('./store.cjs'),{secureBpmTransport}=require('../bpm/api.cjs'); function bodyKeys(body,keys){if(!body||Array.isArray(body)||Object.keys(body).some(k=>!keys.includes(k)))throw fail('助手请求包含不支持的字段。');} -async function assistantApi({assistant,user,sessionId,route,method,body,request,reply,workspace,trustedProxy=false}){ +async function assistantApi({assistant,user,sessionId,route,method,body,request,response,streams,authenticateStream,reply,workspace,trustedProxy=false}){ if(!route.startsWith('/api/assistant'))return false;if(!assistant)throw fail('DSH 助手服务未启动。',503);const principal={user,sessionId}; if(route==='/api/assistant'&&method==='GET'){const settings=assistant.store.settings();reply(200,{settings:user.role==='admin'?settings:{enabled:settings.enabled,allowActions:settings.allowActions,model:settings.model},skills:require('./skills.cjs').projectSkills(),usage:assistant.store.usage(),conversations:assistant.store.conversations(user.id)});return true;} + if(route==='/api/assistant/context'&&method==='GET'){reply(200,require('./diagnostic-context.cjs').diagnosticContext(assistant.deps,user));return true;} + const eventRoute=/^\/api\/assistant\/conversations\/([\w-]+)\/(events|stream)$/.exec(route); + if(eventRoute&&method==='GET'){ + const params=new URL(request.url,'http://localhost').searchParams; + if([...params.keys()].some(k=>k!=='after')||params.getAll('after').length>1)throw fail('事件查询参数无效。'); + const raw=eventRoute[2]==='stream'&&request.headers['last-event-id']!==undefined?request.headers['last-event-id']:params.get('after')??'0'; + if(typeof raw!=='string'||!/^\d+$/.test(raw)||!Number.isSafeInteger(Number(raw)))throw fail('事件游标无效。'); + const after=Number(raw),[_,id,kind]=eventRoute; + assistant.store.row(id,user.id);if(after>assistant.store.eventCursor(id,user.id))throw fail('事件游标超过会话范围。'); + if(kind==='events')reply(200,assistant.store.events(id,user.id,{after})); + else streams.open({request,response,id,user,after,authenticate:authenticateStream}); + return true; + } if((route==='/api/assistant/settings'||route==='/api/assistant/check')&&method==='POST'){ if(user.role!=='admin')throw fail('仅管理员可以配置或检查 DSH。',403);if(!secureBpmTransport(request,trustedProxy))throw fail('请在部署机本地或 HTTPS 页面维护模型配置。',403); if(route.endsWith('/settings')){const saved=assistant.store.saveSettings(body);workspace?.record(user,'配置 DSH 助手',saved.enabled?'已启用':'已暂停');reply(200,saved);}else{bodyKeys(body,[]);reply(200,await assistant.check());}return true; } if(route==='/api/assistant/operations'&&method==='GET'){const params=new URL(request.url,'http://localhost').searchParams;if([...params.keys()].some(k=>k!=='beforeId')||params.getAll('beforeId').length>1)throw fail('操作记录查询参数无效。');const beforeId=params.has('beforeId')?Number(params.get('beforeId')):undefined;if(beforeId!==undefined&&(!Number.isSafeInteger(beforeId)||beforeId<1))throw fail('操作记录游标无效。');reply(200,{events:assistant.operations(principal,{beforeId})});return true;} if(route==='/api/assistant/conversations'&&method==='POST'){bodyKeys(body,[]);reply(201,assistant.store.create(user.id));return true;} - if(route==='/api/assistant/conversations'&&method==='GET'){const params=new URL(request.url,'http://localhost').searchParams,filters={};for(const [key,value]of params){if(!['scope','page','pageSize'].includes(key))throw fail('会话查询参数无效。');filters[key]=key==='scope'?value:Number(value);}reply(200,assistant.store.listConversations(user.id,filters));return true;} + if(route==='/api/assistant/conversations'&&method==='GET'){const params=new URL(request.url,'http://localhost').searchParams,filters={};for(const [key,value]of params){if(!['scope','page','pageSize','query'].includes(key)||params.getAll(key).length!==1)throw fail('会话查询参数无效。');filters[key]=['scope','query'].includes(key)?value:Number(value);}reply(200,filters.query?await require('./conversation-search.cjs').search(assistant.store,user.id,filters):assistant.store.listConversations(user.id,filters));return true;} const history=/^\/api\/assistant\/conversations\/([\w-]+)\/(archive|restore|continue)$/.exec(route); if(history&&method==='POST'){bodyKeys(body,['version']);const result=assistant.store[{archive:'archive',restore:'restore',continue:'continueConversation'}[history[2]]](history[1],user.id,body);workspace?.record(user,'管理个人助手会话',history[2]);reply(200,result);return true;} const match=/^\/api\/assistant\/conversations\/([\w-]+)(?:\/(messages|repair-messages|cancel)|\/actions\/([\w-]+)\/execute)?$/.exec(route); @@ -18,7 +31,7 @@ async function assistantApi({assistant,user,sessionId,route,method,body,request, if(!action&&!actionId&&method==='GET'){reply(200,assistant.store.conversation(id,user.id));return true;} if(method==='POST'){ if(action==='repair-messages'){bodyKeys(body,['text','paths']);reply(202,assistant.sendRepair(id,principal,body.text,body.paths));return true;} - if(action==='messages'){bodyKeys(body,['text']);reply(202,assistant.send(id,principal,body.text));return true;} + if(action==='messages'){bodyKeys(body,['text','diagnostic','requestId']);const diagnostic=require('./diagnostic-context.cjs').validateDiagnostic(body.diagnostic,assistant.deps,user);reply(202,assistant.send(id,principal,body.text,{diagnostic,requestId:body.requestId}));return true;} bodyKeys(body,[]);if(action==='cancel'){reply(200,assistant.cancel(id,principal));return true;} if(actionId){reply(200,await assistant.executeAction(id,actionId,principal));return true;} } diff --git a/src/modules/assistant/conversation-search.cjs b/src/modules/assistant/conversation-search.cjs new file mode 100644 index 0000000..27185e5 --- /dev/null +++ b/src/modules/assistant/conversation-search.cjs @@ -0,0 +1,17 @@ +'use strict'; +const {setImmediate:yieldLoop}=require('node:timers/promises'); +const fail=message=>Object.assign(new Error(message),{status:400}); +async function search(store,owner,{scope='active',page=1,pageSize=25,query}){ + if(typeof query!=='string'||query.length>100||!['active','archived'].includes(scope)||!Number.isSafeInteger(page)||page<1||!Number.isSafeInteger(pageSize)||pageSize<1||pageSize>50)throw fail('会话搜索条件无效。'); + const term=query.trim().toLocaleLowerCase(),archived=Number(scope==='archived'),maximum=archived?2000:50; + const count=store.db.prepare('SELECT COUNT(*) n FROM conversations WHERE owner=? AND archived=?').get(owner,archived).n,found=[]; + // Capture IDs once so a concurrent update cannot shift offsets and skip rows. + const rows=store.db.prepare('SELECT id,payload,created_at,updated_at FROM conversations WHERE owner=? AND archived=? ORDER BY updated_at DESC,rowid DESC LIMIT ?').all(owner,archived,maximum); + for(let offset=0;offsetmaximum}}; +} +module.exports={search}; diff --git a/src/modules/assistant/diagnostic-context.cjs b/src/modules/assistant/diagnostic-context.cjs new file mode 100644 index 0000000..b076d0e --- /dev/null +++ b/src/modules/assistant/diagnostic-context.cjs @@ -0,0 +1,26 @@ +'use strict'; +const {canReadConnection}=require('../order-rules/access.cjs'); +const fail=(message,status=400)=>Object.assign(new Error(message),{status}); +const COMMANDS=Object.freeze(['help','status','bpm','storage','archive']); +function canReadJob(deps,user,job){ + if(user.role==='admin')return true; + const connectionId=job?.connectionId||job?.metadata?.connectionId||job?.source?.connectionId; + return canReadConnection(deps.workspace,user,connectionId); +} +function diagnosticContext(deps,user){ + const value=require('./policy.cjs').snapshot(deps,user); + return {...value,observedAt:value.at,scope:{runs:{limit:10},archives:{limit:15},jobs:{limit:15},exceptions:{limit:15},business:{limit:15}},commands:COMMANDS}; +} +function validateDiagnostic(value,deps,user){ + if(value===undefined)return undefined; + if(!value||Array.isArray(value)||typeof value!=='object'||Object.keys(value).some(k=>!['command','targetId'].includes(k))||!COMMANDS.includes(value.command))throw fail('此诊断命令未开放。'); + if(['help','status'].includes(value.command)){ + if(value.targetId!==undefined)throw fail('此命令不接受目标。'); + return {command:value.command}; + } + if(typeof value.targetId!=='string'||!/^[\w-]{1,100}$/.test(value.targetId))throw fail('请选择有效诊断目标。'); + const current=diagnosticContext(deps,user),rows={bpm:current.connections,storage:current.servers,archive:current.archives}[value.command]; + if(!rows.some(item=>item.id===value.targetId))throw fail('诊断目标不可见或已变化。',403); + return {command:value.command,targetId:value.targetId}; +} +module.exports={diagnosticContext,validateDiagnostic,canReadJob,COMMANDS}; diff --git a/src/modules/assistant/event-stream.cjs b/src/modules/assistant/event-stream.cjs new file mode 100644 index 0000000..d55d1bc --- /dev/null +++ b/src/modules/assistant/event-stream.cjs @@ -0,0 +1,31 @@ +'use strict'; +const fail=(message,status=400)=>Object.assign(new Error(message),{status}); +// SSE and polling read the same durable log. Polling the log also closes the +// replay-to-live race without creating another in-memory source of truth. +class AssistantStreams{ + constructor({store,heartbeatMs=15000,tickMs=250}){this.store=store;this.heartbeatMs=heartbeatMs;this.tickMs=tickMs;this.clients=new Set();this.closed=false;} + open({request,response,id,user,after,authenticate}){ + if(this.closed)throw fail('助手事件服务正在停止。',503); + if(this.clients.size>=30||[...this.clients].filter(c=>c.owner===user.id).length>=2)throw fail('事件连接过多,请稍后重试或使用轮询。',429); + const client={owner:user.id,response};this.clients.add(client);let cursor=after,ended=false,lastHeartbeat=Date.now(); + const close=()=>{if(ended)return;ended=true;clearInterval(timer);this.clients.delete(client);response.end();};client.close=close; + const write=frame=>{if(ended||response.destroyed)return false;if(response.writableLength+Buffer.byteLength(frame)>256*1024){close();return false;}response.write(frame);return true;}; + const pump=()=>{ + if(ended)return; + try{ + const now=Date.now();if(now-lastHeartbeat>=this.heartbeatMs){ + const current=authenticate?.();if(!current||current.id!==user.id||current.role!==user.role||current.username!==user.username){write('event: auth_required\ndata: {"status":401}\n\n');close();return;} + this.store.row(id,user.id);write(': heartbeat\n\n');lastHeartbeat=now; + } + const batch=this.store.events(id,user.id,{after:cursor}); + for(const event of batch.events){if(!write('id: '+event.seq+'\nevent: assistant_event\ndata: '+JSON.stringify(event)+'\n\n'))return;cursor=event.seq;} + }catch{write('event: stream_error\ndata: {"status":503}\n\n');close();} + }; + const timer=setInterval(pump,this.tickMs);timer.unref?.(); + response.once('close',close); + response.writeHead(200,{'Content-Type':'text/event-stream; charset=utf-8','Cache-Control':'no-store','X-Accel-Buffering':'no','Connection':'keep-alive'});response.flushHeaders?.(); + pump();if(cursor===after)write(': connected\n\n'); + } + close(){this.closed=true;for(const client of [...this.clients])client.close();} +} +module.exports={AssistantStreams}; diff --git a/src/modules/assistant/policy.cjs b/src/modules/assistant/policy.cjs index 09f7387..f3e85d6 100644 --- a/src/modules/assistant/policy.cjs +++ b/src/modules/assistant/policy.cjs @@ -7,8 +7,9 @@ function snapshot({workspace,scanner,storage,dashboard,orderRules,orderExecution const connections=w.connections.filter(authorized).map(c=>({id:c.id,name:redact(c.name),status:c.status,checkedAt:c.checkedAt})),ids=new Set(connections.map(c=>c.id)); const runs=(scanner?.store.status().runs||[]).filter(r=>ids.has(r.connectionId)).slice(0,10).map(r=>({connectionId:r.connectionId,status:r.status,startedAt:r.startedAt,finishedAt:r.finishedAt,seen:r.seen,added:r.added,message:redact(r.message)})); const servers=(storage?.store.servers()||[]).map(s=>({id:s.id,name:redact(s.name),enabled:s.enabled,state:{readable:s.state.readable,writable:s.state.writable,message:redact(s.state.message)}})); - const archives=(storage?.store.archives()||[]).slice(0,15).map(a=>({id:a.id,serverId:a.serverId,jobId:a.jobId,status:a.status,orderNumber:a.orderNumber,error:redact(a.error)})); - const jobs=(dashboard?.recentJobs?dashboard.recentJobs(15):dashboard?.jobs()||[]).slice(0,15).map(j=>({jobId:j.jobId,status:j.status,orderNumber:j.metadata?.order,error:redact(j.error)})); + const readable=require('./diagnostic-context.cjs').canReadJob,jobRows=(dashboard?.recentJobs?dashboard.recentJobs(100):dashboard?.jobs()||[]),jobMap=new Map(jobRows.map(j=>[j.jobId,j])); + const archives=(storage?.store.archives()||[]).filter(a=>user.role==='admin'||readable({workspace},user,a)||readable({workspace},user,jobMap.get(a.jobId))).slice(0,15).map(a=>({id:a.id,serverId:a.serverId,jobId:a.jobId,status:a.status,orderNumber:a.orderNumber,error:redact(a.error)})); + const jobs=jobRows.filter(j=>readable({workspace},user,j)).slice(0,15).map(j=>({jobId:j.jobId,status:j.status,orderNumber:j.metadata?.order,error:redact(j.error)})); const exceptions=w.exceptions.filter(e=>user.role==='admin'||e.owner===user.username).slice(0,15).map(e=>({id:e.id,title:redact(e.title),status:e.status,component:e.component,owner:e.owner})); return {at:new Date().toISOString(),role:user.role,connections,runs,servers,archives,jobs,exceptions,business:require('./business-context.cjs').businessContext({orderRules,workspace},user),fieldMapping:require('./field-skill.cjs').coverage({workspace,orderRules,orderExecution},user)}; } @@ -22,7 +23,7 @@ function checkAction(action,deps,user){ } if(action.kind==='scan_bpm'){const c=deps.workspace?.getConnection(action.targetId);if(!c||c.status==='disabled'||!(user.role==='admin'||c.owner===user.username))throw fail('没有扫描此 BPM 连接的权限。',403);} if(action.kind==='check_storage'){if(user.role!=='admin')throw fail('存储连接检查仅管理员可执行。',403);const s=deps.storage?.store.servers().find(s=>s.id===action.targetId);if(!s?.enabled)throw fail('存储服务器不存在或已停用。',409);} - if(action.kind==='retry_archive'){const a=deps.storage?.store.archives().find(a=>a.id===action.targetId);if(!a||!['error','interrupted'].includes(a.status))throw fail('仅可重试已明确失败的归档记录。',409);const s=deps.storage.store.servers().find(s=>s.id===a.serverId);if(!s?.enabled)throw fail('归档服务器不可用。',409);} + if(action.kind==='retry_archive'){const a=deps.storage?.store.archives().find(a=>a.id===action.targetId);if(!a||!['error','interrupted'].includes(a.status))throw fail('仅可重试已明确失败的归档记录。',409);if(user.role!=='admin'&&!snapshot(deps,user).archives.some(row=>row.id===a.id))throw fail('没有重试此归档的权限。',403);const s=deps.storage.store.servers().find(s=>s.id===a.serverId);if(!s?.enabled)throw fail('归档服务器不可用。',409);} return action; } function parseResponse(raw,deps,user){ diff --git a/src/modules/dashboard/auth.cjs b/src/modules/dashboard/auth.cjs index 3ffafd9..d7448e2 100644 --- a/src/modules/dashboard/auth.cjs +++ b/src/modules/dashboard/auth.cjs @@ -95,6 +95,10 @@ const handled=(...args)=>{reply(...args);return {handled:true};}; if(route==='/api/logout' && request.method==='POST'){sessions.revoke(token);response.setHeader('Set-Cookie',`${sessionCookieName}=; HttpOnly; SameSite=Strict; Path=/; Max-Age=0${encryptedTransport?'; Secure':''}`);if(bpmSessions)try{await bpmSessions.releaseSession(token);}catch{fail(502,'登录窗口关闭失败,请稍后重试。');}return handled(200,{ok:true});} return {user,token}; } -return {authenticate,close:()=>sessions.close()}; +function current(request){ + const token=sessionCookiePattern.exec(request.headers.cookie||'')?.[1],session=sessions.lookup(token),user=session?store.user(session.userId):null; + return user&&user.enabled!==false&&session.passwordVersion===store.passwordVersion(user.id)&&!cleanup.revoked(token)?user:null; +} +return {authenticate,current,close:()=>sessions.close()}; } module.exports={createAuth}; diff --git a/tests/assistant/workspace-http.test.cjs b/tests/assistant/workspace-http.test.cjs new file mode 100644 index 0000000..a3cf086 --- /dev/null +++ b/tests/assistant/workspace-http.test.cjs @@ -0,0 +1,62 @@ +'use strict'; +const {test}=require('node:test'),assert=require('node:assert/strict'),fs=require('node:fs/promises'),os=require('node:os'),path=require('node:path'); +async function fixture(t){ + const {Store}=require('../../src/modules/dashboard/store.cjs'),{AssistantStore}=require('../../src/modules/assistant/store.cjs'),{AssistantService}=require('../../src/modules/assistant/service.cjs'),{createDashboard}=require('../../src/app/dashboard.cjs'); + const dir=await fs.mkdtemp(path.join(os.tmpdir(),'dsh-workspace-http-')),users=new Store(path.join(dir,'users'));users.bootstrap('admin','Test-password-123');users.addUser({username:'member',role:'operator',password:'Test-password-123'},'admin'); + const store=new AssistantStore(path.join(dir,'assistant'));let calls=0,checks=0; + const connections=[{id:'own',name:'Member connection',owner:'member',status:'connected'},{id:'foreign',name:'Foreign connection',owner:'someone',status:'connected'}]; + const workspace={snapshot:()=>({connections,exceptions:[]}),getConnection:id=>connections.find(c=>c.id===id)}; + const assistant=new AssistantService({store,workspace,dashboard:users,storage:{store:{servers:()=>[{id:'shared',name:'Shared storage',state:{readable:true},enabled:true}],archives:()=>[]},check:()=>{checks++;}},runtime:{chat:async()=>{calls++;return JSON.stringify({reply:'diagnosed',actions:[]});}}}); + const server=createDashboard({store:users,assistant,outputDir:dir});await new Promise(r=>server.listen(0,'127.0.0.1',r)); + t.after(async()=>{server.closeAssistantStreams?.();await assistant.stop();server.closeAllConnections();await new Promise(r=>server.close(r));store.close();await fs.rm(dir,{recursive:true,force:true});}); + const base='http://127.0.0.1:'+server.address().port; + const call=(route,body,cookie,extra={})=>fetch(base+route,{method:body===undefined?'GET':'POST',headers:{...(body===undefined?{}:{Origin:base,'Content-Type':'application/json'}),...(cookie?{Cookie:cookie}:{}),...extra},body:body===undefined?undefined:JSON.stringify(body)}); + const login=async name=>(await call('/api/login',{username:name,password:'Test-password-123'})).headers.get('set-cookie').split(';')[0]; + return {store,assistant,server,users,call,login,base,calls:()=>calls,checks:()=>checks}; +} +test('context reads authorized diagnostics without calling a model or live service',async t=>{ + const f=await fixture(t),cookie=await f.login('member');assert.equal((await f.call('/api/assistant/context')).status,401); + const r=await f.call('/api/assistant/context',undefined,cookie);assert.equal(r.status,200);const data=await r.json(); + assert.deepEqual(data.connections.map(c=>c.id),['own']);assert.ok(data.observedAt);assert.equal(f.calls(),0);assert.equal(f.checks(),0);assert.doesNotMatch(JSON.stringify(data),/Foreign connection|password|apiKey/); +}); +test('diagnosis and recovery cannot use another connection owner\'s export or archive',async t=>{ + const f=await fixture(t),cookie=await f.login('member');f.assistant.deps.dashboard={jobs:()=>[{jobId:'own-pdf',connectionId:'own'},{jobId:'other-pdf',connectionId:'foreign'}]}; + f.assistant.deps.storage.store.archives=()=>[{id:'mine',jobId:'own-pdf',serverId:'shared',status:'error'},{id:'secret',jobId:'other-pdf',serverId:'shared',status:'error'}]; + const data=await(await f.call('/api/assistant/context',undefined,cookie)).json();assert.deepEqual(data.jobs.map(x=>x.jobId),['own-pdf']);assert.deepEqual(data.archives.map(x=>x.id),['mine']); + assert.throws(()=>require('../../src/modules/assistant/policy.cjs').checkAction({kind:'retry_archive',targetId:'secret'},f.assistant.deps,{username:'member',role:'operator'}),e=>e.status===403); +}); +test('diagnostic command targets are validated at the API rather than trusted from display names',async t=>{ + const f=await fixture(t),cookie=await f.login('member'),created=await(await f.call('/api/assistant/conversations',{},cookie)).json(); + f.store.saveSettings({...f.store.settings(),enabled:true,runtimePath:process.execPath,apiBase:'https://fixture.example/anthropic',model:'test',apiKey:'TEST_ONLY_KEY',allowActions:false}); + const route='/api/assistant/conversations/'+created.id+'/messages'; + assert.equal((await f.call(route,{text:'analyze',diagnostic:{command:'bpm',targetId:'foreign'}},cookie)).status,403); + assert.equal((await f.call(route,{text:'analyze',diagnostic:{command:'shell'}},cookie)).status,400); + const sent=await f.call(route,{text:'analyze',diagnostic:{command:'bpm',targetId:'own'},requestId:'diagnostic-test'},cookie);assert.equal(sent.status,202); + const turn=await sent.json();await f.assistant.running.get(turn.id)?.task;assert.equal(f.calls(),1); +}); +test('durable event HTTP rejects cross-owner and invalid cursors and SSE can resume then close',async t=>{ + const f=await fixture(t),cookie=await f.login('admin'),other=await f.login('member'),c=await(await f.call('/api/assistant/conversations',{},cookie)).json(); + const turn=f.store.beginTurn(c.id,f.users.users().find(u=>u.username==='admin').id,'sample');f.store.updateTurn(turn.id,'success',{reply:'answer'}); + const prefix='/api/assistant/conversations/'+c.id; + assert.equal((await f.call(prefix+'/events?after=0',undefined,other)).status,404); + for(const query of ['-1','1.5','999999','bad'])assert.equal((await f.call(prefix+'/events?after='+query,undefined,cookie)).status,400); + const response=await f.call(prefix+'/events?after=0',undefined,cookie);assert.equal(response.status,200);const replay=await response.json();assert.ok(replay.events.length>=2); + const stream=await f.call(prefix+'/stream?after=0',undefined,cookie,{'Last-Event-ID':String(replay.events[0].seq)});assert.equal(stream.status,200);assert.match(stream.headers.get('content-type'),/text\/event-stream/);assert.equal(stream.headers.get('x-accel-buffering'),'no'); + const reader=stream.body.getReader(),first=await reader.read();assert.match(new TextDecoder().decode(first.value),/assistant_event/);await reader.cancel(); + const state=await(await f.call(prefix,undefined,cookie)).json();assert.equal(state.eventCursor,replay.nextCursor); +}); +test('SSE refuses excess streams and releases resources on shutdown',async t=>{ + const f=await fixture(t),cookie=await f.login('admin'),c=await(await f.call('/api/assistant/conversations',{},cookie)).json(),route='/api/assistant/conversations/'+c.id+'/stream?after=0'; + const a=await f.call(route,undefined,cookie),b=await f.call(route,undefined,cookie);assert.equal(a.status,200);assert.equal(b.status,200);assert.equal((await f.call(route,undefined,cookie)).status,429); + f.server.closeAssistantStreams();await a.body.cancel();await b.body.cancel(); +}); +test('an open SSE stream terminates after its login cookie is revoked',{timeout:30000},async t=>{ + const f=await fixture(t),cookie=await f.login('admin'),c=await(await f.call('/api/assistant/conversations',{},cookie)).json(); + const response=await f.call('/api/assistant/conversations/'+c.id+'/stream?after=0',undefined,cookie),reader=response.body.getReader();await f.call('/api/logout',{},cookie);let text='';while(true){const part=await reader.read();if(part.done)break;text+=new TextDecoder().decode(part.value);}assert.match(text,/auth_required/); +}); +test('title search reaches beyond the visible page and remains owner scoped',async t=>{ + const f=await fixture(t),cookie=await f.login('admin'),owner=f.users.users().find(u=>u.username==='admin').id,other=f.users.users().find(u=>u.username==='member').id; + for(let i=0;i<27;i++){const c=f.store.create(owner);f.store.beginTurn(c.id,owner,i===0?'UNIQUE_OLDER_TITLE':'Ordinary '+i);} + const foreign=f.store.create(other);f.store.beginTurn(foreign.id,other,'UNIQUE_OLDER_TITLE'); + const response=await f.call('/api/assistant/conversations?scope=active&page=1&pageSize=25&query=unique_older_title',undefined,cookie);assert.equal(response.status,200);const result=await response.json();assert.equal(result.total,1);assert.equal(result.items[0].title,'UNIQUE_OLDER_TITLE');assert.notEqual(result.items[0].id,foreign.id);assert.equal(result.search.truncated,false); +});