diff --git a/backend/db.py b/backend/db.py index 25f4068..6d5f253 100644 --- a/backend/db.py +++ b/backend/db.py @@ -114,6 +114,12 @@ def initialize_database() -> None: ON activation_codes (status); """ ) + connection.execute( + """ + DELETE FROM activation_codes + WHERE status != 'unused' + """ + ) connection.execute( """ DELETE FROM subtitles @@ -464,6 +470,7 @@ def list_activation_codes() -> list[dict[str, object]]: SELECT activation_codes.*, users.email AS used_by_username FROM activation_codes LEFT JOIN users ON users.id = activation_codes.used_by_user_id + WHERE activation_codes.status = 'unused' ORDER BY activation_codes.created_at DESC, activation_codes.id DESC """ ).fetchall() diff --git a/tests/auth_helpers_test.py b/tests/auth_helpers_test.py index cde6872..8f6f9e6 100644 --- a/tests/auth_helpers_test.py +++ b/tests/auth_helpers_test.py @@ -66,7 +66,40 @@ def test_activation_code_registers_user_once(): raise AssertionError("used activation code should not register another user") +def test_initialize_database_removes_legacy_used_activation_codes(): + with TempDatabase(): + with db.get_connection() as connection: + cursor = connection.execute( + """ + INSERT INTO users (email, password_hash, display_name) + VALUES ('legacy-user', 'hash', 'legacy-user') + """ + ) + connection.execute( + """ + INSERT INTO activation_codes ( + code, created_by, used_by_user_id, used_at, status + ) + VALUES ('SL-USED12-USED34-USED56', 'admin', ?, CURRENT_TIMESTAMP, 'used') + """, + (int(cursor.lastrowid),), + ) + + with db.get_connection() as connection: + count = connection.execute( + "SELECT COUNT(*) AS count FROM activation_codes WHERE status = 'used'" + ).fetchone()["count"] + assert count == 1 + + db.initialize_database() + + with db.get_connection() as connection: + count = connection.execute("SELECT COUNT(*) AS count FROM activation_codes").fetchone()["count"] + assert count == 0 + + if __name__ == "__main__": test_password_hash_roundtrip() test_auth_token_roundtrip_and_tamper_rejection() test_activation_code_registers_user_once() + test_initialize_database_removes_legacy_used_activation_codes()