abaishu0730
changed title from fix: add task list selection controls to fix(ui): add task selection controls and preserve Acrylic on return2026-11-03 10:54:17 +08:00
abaishu0730
changed title from fix(ui): add task selection controls and preserve Acrylic on return to fix(ui): restore task navigation controls and preserve Acrylic2026-11-03 11:03:08 +08:00
Review result: all 4 CI jobs succeeded. On the clean PR15 commit, the changed-test set passed 292 tests with 1 skip (the skip only reflects the missing local DxDesigner 7.9.5 type library). P2 finding: history_recording.py::_MUTATIONS omits create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project. Each entry point writes tasks/rules/projects/target plans, but _idle_quick_run_operation only calls record_operation for names in this set. Successful calls therefore never appear in Operation History and their change details are lost. Please include every database-mutating entry point and add regression coverage before merging.
Review result: all 4 CI jobs succeeded. On the clean PR15 commit, the changed-test set passed 292 tests with 1 skip (the skip only reflects the missing local DxDesigner 7.9.5 type library). P2 finding: history_recording.py::_MUTATIONS omits create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project. Each entry point writes tasks/rules/projects/target plans, but _idle_quick_run_operation only calls record_operation for names in this set. Successful calls therefore never appear in Operation History and their change details are lost. Please include every database-mutating entry point and add regression coverage before merging.
Follow-up review of latest commit c86b0ee: the previous P2 finding is fixed. create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project now record changes at the correct SQL commit boundary; the new regression suite covers replay, unchanged operations, cancellation, rollback on history-write failure, and concurrent history writes. Targeted clean-commit tests pass: 119 passed. All 4 CI jobs for c86b0ee are successful. I found no remaining actionable issue; this PR is ready for approval from the code-review perspective.
Follow-up review of latest commit c86b0ee: the previous P2 finding is fixed. create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project now record changes at the correct SQL commit boundary; the new regression suite covers replay, unchanged operations, cancellation, rollback on history-write failure, and concurrent history writes. Targeted clean-commit tests pass: 119 passed. All 4 CI jobs for c86b0ee are successful. I found no remaining actionable issue; this PR is ready for approval from the code-review perspective.
恢复时 execution_journal.py:344-345:elif record is not None and record['state'] in {'prepared','uncertain'}: raise TaskCenterError('quick_run_uncertain','上次执行尝试没有完整结果,不能重复派发。')。
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
这次变更让工作台提供独立操作历史,并解决同一任务继续或重启时依赖状态文件重新派发已完成替换的问题。任务保存冻结执行范围和逐项完成回执;证据缺失或矛盾时停止核验,已完成项不会因清空历史、重新生成队列编号而重跑。
界面与行为
执行保护
任务数据库升级到版本 8,增加独立的历史、执行轮次、尝试回执、目标占用和最近已核验图页语义状态。完成回执、历史与进度同事务提交;原生快照、报告和尝试身份绑定独立证明文件摘要。继续前核对最近核验状态,发现外部变化或证明损坏时阻断。
旧版未绑定的多工程服务接口保留原有兼容语义;当前 UI 的独立工程任务采用本次确认的失败暂缓策略。DSH 源码没有改动。
验证
Windows 11 build 26200 原生窗口验收通过:历史搜索、详情、实际 Qt 确认清空、清空后任务保留、两轮 Chromium 导航后的 Acrylic、降低透明度与 980×700 布局。未调用真实 CAD 或模型,未构建或发布 EXE。
具体故障注入、实施决定和验收说明见
docs/testing/2026-11-03-operation-history-execution.md;用户说明见docs/user/operation-history.md。已同步 main 的 #17 并解决合并冲突。DSH 界面宿主文件完整采用 main,PR 对 DSH 源码没有差异。同步后再次验证两轮 WebEngine 导航的实际毛玻璃差分(20.18,表格 0,句柄不变),以及独立 Windows 原生确认框搜索/详情/清空(历史和表格均为 0、任务保留)。整套截图流同步后未完整跑通,后续被外部窗口遮挡保护中止,完整经过和替代原生探针结果已写入验收说明;未截取其他窗口。
审查评论 179:补齐操作历史入口
助手创建任务、采集位号计划、重新读取绑定工程此前能保存业务改动,却没有操作历史;本次补齐这三个入口,并修复同类检查发现的 Value 策略入口绕过历史捕获的问题。历史页面同步提供对应中文操作名称。
业务变更和历史在同一数据库事务提交,历史写入失败时一并回滚。采集工程和文件状态检查在历史事务外完成,只捕获短保存阶段;无变化刷新、重复采集及助手请求重放不增加重复历史。未修改 DSH 业务源码。
验证:新增 13 项真实服务回归通过;干净原提交的 4 项对应记录断言均因缺少历史失败。兼容性回归 282 项通过,独立代码审查无可操作发现。
默认全套为 1245 通过、1 项
cscript.exe等待超时(原有 15 秒限制),不是全部通过;全套结束后,该失败分支在原同步工作目录单独复跑通过。干净原提交和当前修复的源码快照在同步目录外运行原生保护完整参数组,分别 5/5 通过;没有放宽测试时限或修改原生保护。详见docs/testing/2026-11-04-pr15-history-entrypoints.md。fix: add task list selection controlsto fix(ui): add task selection controls and preserve Acrylic on returnfix(ui): add task selection controls and preserve Acrylic on returnto fix(ui): restore task navigation controls and preserve Acrylicfix(ui): restore task navigation controls and preserve Acrylicto UI:完善毛玻璃工作台、操作历史和同任务安全续跑Review result: all 4 CI jobs succeeded. On the clean PR15 commit, the changed-test set passed 292 tests with 1 skip (the skip only reflects the missing local DxDesigner 7.9.5 type library). P2 finding: history_recording.py::_MUTATIONS omits create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project. Each entry point writes tasks/rules/projects/target plans, but _idle_quick_run_operation only calls record_operation for names in this set. Successful calls therefore never appear in Operation History and their change details are lost. Please include every database-mutating entry point and add regression coverage before merging.
Follow-up review of latest commit
c86b0ee: the previous P2 finding is fixed. create_assistant_project_tasks, collect_target_inventory, and refresh_bound_project now record changes at the correct SQL commit boundary; the new regression suite covers replay, unchanged operations, cancellation, rollback on history-write failure, and concurrent history writes. Targeted clean-commit tests pass: 119 passed. All 4 CI jobs forc86b0eeare successful. I found no remaining actionable issue; this PR is ready for approval from the code-review perspective.回审已合并 PR #15(
UI:完善毛玻璃工作台、操作历史和同任务安全续跑)merge
453d288,first-parent diff 54 文件 +4,026/−120。行号按origin/main(aff228e)复核。结论:一条已核实的 P1(任务级卡死)值得修;子代理报的第二条 P1 我在代码里没有复现,附反证请作者确认。
P1 派发前就把执行项置为
prepared,失败后没有释放路径 → 任务永久卡住证据链(我逐行核对):
quick_run.py:468附近:self.write_expected_baselines(...)之后立刻journal_attempt = journal.claim(task_id, row),然后才组装并启动 worker(:472-500)。execution_journal.py:368-369:claim直接把记录写成state='prepared'。QuickPartReplace.vbs基线检查在写snapshot-<job>.tsv之前)或进程启动/写文件阶段失败,这条记录就停在prepared,状态文件里没有任何对应 job 的终态行。execution_journal.py:344-345:elif record is not None and record['state'] in {'prepared','uncertain'}: raise TaskCenterError('quick_run_uncertain','上次执行尝试没有完整结果,不能重复派发。')。execution_journal.py:364:if record['state']!='pending': raise ... 禁止再次派发。execution_journal.py,没有prepared → pending/failed的释放代码;needs_reconciliation(:254-259)只要还有 prepared 就一直为真。后果:一次 worker 崩溃/启动失败/基线校验失败,就能让整个任务进入"不能继续、不能重试"的状态;用户只能新建同名任务或直接改 SQLite。
建议(对应设计文档承诺的"证明未修改可重新领取"):
release_prepared_attempt(task_id, operation_key, reason):仅当能证明"未写入"(status.tsv 无该 job 行 + 无snapshot-<job>.tsv+ 无post-state-<job>.tsv+ 无 rollback marker)时把记录改回pending并记一条证据;证明不了就保持prepared并提示人工核验。claim()里把prepared与uncertain区分开:prepared(还没到写阶段)允许走上面的释放,uncertain继续拒绝。对子代理第二条 P1 的反证(请作者确认是不是我漏了路径)
子代理报"升级后旧成功项缺
post-state,strict 导入必然失败,在途任务无法续跑"(引用execution_proof.py:31-47)。我在restore主循环里看到:execution_journal.py:326-328:已成功项在恢复时不会重新计算 strict 证明,所以"旧成功项缺 post-state → strict 导入失败"这条路径在当前代码里不成立。如果作者指的是别的入口(例如verify_source_checkpoint/affirmative/expected_baselines对旧基线的校验),请给出具体调用点,我再核对。P3(需要作者确认,我没有核实到可复现路径)
quick_run_snapshot.py:17-21的 879 基线错误判定只对batch_failed生效,对 hard failure 是死分支——建议作者确认是否还有别的分支覆盖 hard failure。做得好的部分
superseded/retry的边界(execution_journal.py:299-347)写得很细:重试只能替换已知失败范围、成功项不重放、execution_target_claims阻止同一位号重新编组;test_safe_user_stop.py:306-430、test_isolated_desktop.py用真实子进程/桌面,不是纯 mock。验证记录
quick_run.py:455-500、execution_journal.py:295-330 / 344-369 / 495-512、quick_run_snapshot.py:1-30均在origin/main上确认。未验证边界
未在真实 DxDesigner 上注入"worker 启动即失败"复现卡死;未审计该 PR 全部 54 文件。